[BUILD] Version opentelemetry_proto/proto_grpc shared libraries #2992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2992 +/- ##
==========================================
+ Coverage 87.12% 87.60% +0.49%
==========================================
Files 200 190 -10
Lines 6109 5870 -239
==========================================
- Hits 5322 5142 -180
+ Misses 787 728 -59 |
|
/easycla |
|
Thanks for the quick responses. The CLA is waiting for a signature from a guy on vacation. If it makes things easier we can close and reopen later |
Thanks for the update. |
|
@Troels51 any updates on CLA? |
|
@esigo. The CLA should now be signed 🎉 |
msiddhu
added a commit
to msiddhu/opentelemetry-cpp
that referenced
this pull request
Aug 20, 2024
* [EXPORTER] Ignore exception when create thread in OTLP file exporter. (open-telemetry#3012) * [BUILD] Update MODULE.bazel (open-telemetry#3015) * [BUILD] Fix build without vcpkg on Windows when gRPC is disabled (open-telemetry#3016) * [BUILD] Add abi_version_no bazel flag. (open-telemetry#3020) * [Code health] Expand iwyu coverage to include unit tests. (open-telemetry#3022) * [BUILD] Version opentelemetry_proto/proto_grpc shared libraries (open-telemetry#2992) * [SEMANTIC CONVENTIONS] Upgrade semantic conventions to 1.27.0 (open-telemetry#3023) * [SDK] Support empty histogram buckets (open-telemetry#3027) * support empty buckets * Update histogram_test.cc * Update histogram_test.cc * test for negative values * fix count * [TEST] Fix sync problems in OTLP File exporter tests. (open-telemetry#3031) --------- Co-authored-by: WenTao Ou <[email protected]> Co-authored-by: Carbo Kuo <[email protected]> Co-authored-by: Manuel Bergler <[email protected]> Co-authored-by: Marc Alff <[email protected]> Co-authored-by: Troels Hoffmeyer <[email protected]> Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After building opentelemetry-cpp with "OTELCPP_VERSIONED_LIBS=ON" I noticed that opentelemetry-proto and opentelemetry-proto-grpc were not versioned
Changes
This versions opentelemetry_proto and opentelemetry_proto_grpc with set_target_version
One question:
Should these be versioned with the opentelemetry-proto version instead of the SDK version?
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes