Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample decision name based on spec update #327

Merged
merged 3 commits into from
Sep 17, 2020

Conversation

ThomsonTan
Copy link
Contributor

Inconsistent naming of sampling decision was updated in OTel trace SDK spec PR, this PR does the renaming to keep conformance with spec.

@ThomsonTan ThomsonTan requested a review from a team September 17, 2020 02:22
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #327 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #327   +/-   ##
=======================================
  Coverage   94.60%   94.60%           
=======================================
  Files         148      148           
  Lines        6651     6651           
=======================================
  Hits         6292     6292           
  Misses        359      359           
Impacted Files Coverage Δ
sdk/include/opentelemetry/sdk/trace/sampler.h 100.00% <ø> (ø)
.../opentelemetry/sdk/trace/samplers/parent_or_else.h 100.00% <ø> (ø)
...ude/opentelemetry/sdk/trace/samplers/probability.h 100.00% <ø> (ø)
sdk/test/trace/tracer_test.cc 99.09% <ø> (ø)
...lude/opentelemetry/sdk/trace/samplers/always_off.h 100.00% <100.00%> (ø)
sdk/src/trace/samplers/parent_or_else.cc 100.00% <100.00%> (ø)
sdk/src/trace/samplers/probability.cc 100.00% <100.00%> (ø)
sdk/src/trace/tracer.cc 70.96% <100.00%> (ø)
sdk/test/trace/always_off_sampler_test.cc 100.00% <100.00%> (ø)
sdk/test/trace/parent_or_else_sampler_test.cc 100.00% <100.00%> (ø)
... and 1 more

@reyang reyang merged commit b827d79 into open-telemetry:master Sep 17, 2020
@ThomsonTan ThomsonTan deleted the Update_sample_name branch November 9, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants