Return Scope object instead of unique_ptr<Scope> from Tracer::WithActiveSpan() #788
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #787
Changes
As mentioned in why nostd::unique_ptr<Scope> not Scope #787 ,
Tracer::WithActiveSpan()
can avoid memory allocation on heap by returning newly createdScope
object instead ofunique_ptr<Scope>
. The copy constructor ofScope
is implicitly deleted because ofunique_ptr
member variable, so this ensures multiple copies are not possible forScope
.Also modified etw::tracer::StartSpan() method to not make span active immediately after creating as this deviates from the specs.
tracer::WithActiveSpan()
should be called explicitly by instrumentation library to make it active. ( cc @maxgolov )For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes