Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definitions for bad_variant_access and dependencies of some examples. #850

Merged
merged 1 commit into from
Jun 12, 2021

Conversation

owent
Copy link
Member

@owent owent commented Jun 11, 2021

Signed-off-by: owent [email protected]

Fixes #849

Changes

  • Move CORE_RUNTIME_LIBS into dependency of opentelemetry_api

    I found all targets link CORE_RUNTIME_LIBS alse depend opentelemetry_api. So I move CORE_RUNTIME_LIBS into dependency of opentelemetry_api for easier usage.

  • Add alias of nostd::bad_variant_access to absl::bad_variant_access when have abseil

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@owent owent requested a review from a team June 11, 2021 08:36
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #850 (6b0c1b8) into main (865b9e7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #850   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files         156      156           
  Lines        6615     6615           
=======================================
  Hits         6316     6316           
  Misses        299      299           
Impacted Files Coverage Δ
api/include/opentelemetry/nostd/variant.h 66.67% <ø> (ø)

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix. I will add CI for ABSIEL.

@lalitb
Copy link
Member

lalitb commented Jun 11, 2021

@owent - will merge it once you rebase the changes.thanks.

+ Add alias of `nostd::bad_variant_access` to `absl::bad_variant_access` when have abseil

Signed-off-by: owent <[email protected]>
@owent
Copy link
Member Author

owent commented Jun 12, 2021

@owent - will merge it once you rebase the changes.thanks.

Done.

@lalitb lalitb merged commit 521ebd8 into open-telemetry:main Jun 12, 2021
@owent owent deleted the fix_issue_834 branch June 13, 2021 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing fix for test for #834 and some examples have different definetions from opentelemetry_api
3 participants