Optimize OtlpHttpExporter to support timeout and cancle #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: owent <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 95.48% 95.49% +0.01%
==========================================
Files 156 156
Lines 6615 6617 +2
==========================================
+ Hits 6316 6318 +2
Misses 299 299
|
Signed-off-by: owent <[email protected]>
|
@open-telemetry/cpp-approvers - I will take the liberty to merge it, as this was a fix for earlier reverted changes from PR #803. |
ThomsonTan
reviewed
Jun 14, 2021
| @@ -65,6 +68,7 @@ struct OtlpHttpExporterOptions | |||
|
|
|||
| // TODO: Enable/disable to verify SSL certificate | |||
| // TODO: Reuqest timeout | |||
There was a problem hiding this comment.
This TODO could be removed?
There was a problem hiding this comment.
Yes. This PR is already merged, maybe it can be remove in another PR later.
There was a problem hiding this comment.
sorry if I merged it a bit earlier. There is a task to remove/handle invalid TODOs from the code base, this can be handled through that if not done before.
3 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: owent [email protected]
Fixes #852
Changes
Use
HttpClientto replaceHttpClientSync.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes