Add Jaeger Thrift HTTP exporter #926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #926 +/- ##
==========================================
+ Coverage 95.43% 95.44% +0.02%
==========================================
Files 158 158
Lines 6749 6749
==========================================
+ Hits 6440 6441 +1
+ Misses 309 308 -1
|
otlp-http exporter uses the test http server provided as part of this repo for functional tests : |
lalitb
approved these changes
Jul 28, 2021
exporters/jaeger/include/opentelemetry/exporters/jaeger/jaeger_exporter.h
Outdated
Show resolved
Hide resolved
ThomsonTan
approved these changes
Jul 28, 2021
|
|
||
| bool isOpen() const override; | ||
|
|
||
| uint32_t read(uint8_t *buf, uint32_t len); |
There was a problem hiding this comment.
Do we need to provide read as it is not used?
There was a problem hiding this comment.
The base Transport class (TTransport::read_virt) will throw if this is invoked and I wasn't sure if the Thrift binary protocol will actually call this method, probably not, but just to be on the safe side 😨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds capability to upload Thrift over HTTP for Jaeger exporter.
Not sure how to automatically test it since we don't have integration tests anywhere, or do we? The UDP exporter is pretty much in the same state.
CHANGELOG.mdupdated for non-trivial changes