Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ENV_PLATFORM flag in UI #616

Closed
austinlparker opened this issue Dec 7, 2022 · 6 comments
Closed

Improve ENV_PLATFORM flag in UI #616

austinlparker opened this issue Dec 7, 2022 · 6 comments
Assignees
Labels
enhancement New feature or request frontend v1.4 required for 1.4 release

Comments

@austinlparker
Copy link
Member

Screenshot 2022-12-07 at 10 02 26 AM

This guy here.

It occludes parts of the UI, and I don't think it actually properly updates right now anyway? We should move this to some other part of the UI (maybe in the footer, idk) or just get rid of it entirely.

@austinlparker austinlparker added the enhancement New feature or request label Dec 7, 2022
@julianocosta89
Copy link
Member

This is populated by the environment variable ENV_PLATFORM.
I personally like it, for blue/green deployments it is actually nice to set different values and easily identify which env you are.

Welllll.... Now that I wrote it, not sure if it makes much sense in our scenario 😅

@puckpuck
Copy link
Contributor

If we do keep this, it needs to be able to be set to any string, and not be bound to an enum.

@austinlparker austinlparker added the v1.4 required for 1.4 release label Feb 6, 2023
@austinlparker austinlparker changed the title Rework the environment visual flag in frontend ENV_PLATFORM in Frontend should accept any string Feb 6, 2023
@austinlparker austinlparker changed the title ENV_PLATFORM in Frontend should accept any string Improve ENV_PLATFORM flag in UI Feb 6, 2023
@austinlparker
Copy link
Member Author

To summarize, the work here is as follows:

  • Move the flag so that it doesn't occlude other UI elements
  • Allow an arbitrary short string to be passed in rather than selecting from an enum

@martinkuba
Copy link
Contributor

martinkuba commented Mar 29, 2023

Would bottom right corner of the footer work? Like this
image

Also, if I change the text from enum to any text, then the flag will always be the same color. The enum is mapped to different colors currently. Just double checking this is ok.

@julianocosta89
Copy link
Member

Bottom right is fine to me

@puckpuck
Copy link
Contributor

I'm ok with no color change as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend v1.4 required for 1.4 release
Projects
None yet
Development

No branches or pull requests

5 participants