use Phoenix 1.6 style #1238
Merged
use Phoenix 1.6 style #1238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoenix 1.7 has deprecated Phoenix.View in favor of Phoenix.Component and moved the get_flash function out of controllers, making us call it directly
tsloughter
approved these changes
Nov 7, 2023
|
@tsloughter thanks for approving. I don't know who's going to merge it, but I'm not authorised to do so ;) |
|
It may take some time bc of kubecon taking everyone's focus :) |
cedricziel
approved these changes
Nov 10, 2023
1 task
There was a problem hiding this comment.
I get these errors when trying to build this:
=> ERROR [featureflagservice builder 21/25] RUN mix assets.deploy 7.9s
------
> [featureflagservice builder 21/25] RUN mix assets.deploy:
1.226
1.226 01:26:32.203 [debug] Downloading esbuild from https://registry.npmjs.org/esbuild-linux-64/0.14.29
2.005
2.005 ../priv/static/assets/app.js 103.1kb
2.005 ../priv/static/assets/app.css 11.3kb
2.005
2.005 ⚡ Done in 38ms
2.294 Compiling 22 files (.erl)
7.072 Compiling 17 files (.ex)
7.813 warning: undefined function live_flash/2 (expected FeatureflagserviceWeb.LayoutView to define such a function or for it to be imported, but none are available)
7.813 lib/featureflagservice_web/templates/layout/live.html.heex:24
7.813
7.826 warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
7.826 lib/featureflagservice_web/templates/feature_flag/form.html.heex:17: FeatureflagserviceWeb.FeatureFlagView."form.html"/1
7.826
7.827 warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
7.827 lib/featureflagservice_web/templates/feature_flag/form.html.heex:24: FeatureflagserviceWeb.FeatureFlagView."form.html"/1
7.827
7.827 warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
7.827 lib/featureflagservice_web/templates/feature_flag/form.html.heex:25: FeatureflagserviceWeb.FeatureFlagView."form.html"/1
7.827
7.827 warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
7.827 lib/featureflagservice_web/templates/feature_flag/form.html.heex:26: FeatureflagserviceWeb.FeatureFlagView."form.html"/1
7.827
7.828 warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
7.828 lib/featureflagservice_web/templates/feature_flag/form.html.heex:28: FeatureflagserviceWeb.FeatureFlagView."form.html"/1
7.828
7.828 warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
7.828 lib/featureflagservice_web/templates/feature_flag/form.html.heex:29: FeatureflagserviceWeb.FeatureFlagView."form.html"/1
7.828
7.828 warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
7.828 lib/featureflagservice_web/templates/feature_flag/form.html.heex:30: FeatureflagserviceWeb.FeatureFlagView."form.html"/1
7.828
7.829 warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
7.829 lib/featureflagservice_web/templates/feature_flag/form.html.heex:33: FeatureflagserviceWeb.FeatureFlagView."form.html"/1
7.829
7.829 warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
7.829 lib/featureflagservice_web/templates/feature_flag/form.html.heex:34: FeatureflagserviceWeb.FeatureFlagView."form.html"/1
7.829
7.829 warning: variable "f" does not exist and is being expanded to "f()", please use parentheses to remove the ambiguity or change the variable name
7.829 lib/featureflagservice_web/templates/feature_flag/form.html.heex:36: FeatureflagserviceWeb.FeatureFlagView."form.html"/1
7.829
7.833
7.833 == Compilation error in file lib/featureflagservice_web/views/layout_view.ex ==
7.833 ** (CompileError) lib/featureflagservice_web/templates/layout/live.html.heex:20: undefined function live_flash/2 (expected FeatureflagserviceWeb.LayoutView to define such a function or for it to be imported, but none are available)
7.833
------
failed to solve: process "/bin/sh -c mix assets.deploy" did not complete successfully: exit code: 1
Some things have changed in LV, these changes
should address that.
- some helpers have moved to Phoenix.Component (live_flash)
- some syntax changes let={f} vs :let={f}
- live_title_tag is now .live_title
|
@joshleecreates thanks for noticing, I think those should be fixed in f2538d8 |
julianocosta89
approved these changes
Nov 21, 2023
julianocosta89
merged commit a958972
into
open-telemetry:renovate/featureflagservice
2 checks passed
austinlparker
added a commit
that referenced
this pull request
Nov 27, 2023
* chore(deps): update featureflagservice * use Phoenix 1.6 style (#1238) * use Phoenix 1.6 style Phoenix 1.7 has deprecated Phoenix.View in favor of Phoenix.Component and moved the get_flash function out of controllers, making us call it directly * fix deprecated LV stuff Some things have changed in LV, these changes should address that. - some helpers have moved to Phoenix.Component (live_flash) - some syntax changes let={f} vs :let={f} - live_title_tag is now .live_title --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> Co-authored-by: Tonći Galić <[email protected]>
jmichalak9
pushed a commit
to jmichalak9/opentelemetry-demo
that referenced
this pull request
Mar 22, 2024
* chore(deps): update featureflagservice * use Phoenix 1.6 style (open-telemetry#1238) * use Phoenix 1.6 style Phoenix 1.7 has deprecated Phoenix.View in favor of Phoenix.Component and moved the get_flash function out of controllers, making us call it directly * fix deprecated LV stuff Some things have changed in LV, these changes should address that. - some helpers have moved to Phoenix.Component (live_flash) - some syntax changes let={f} vs :let={f} - live_title_tag is now .live_title --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Austin Parker <[email protected]> Co-authored-by: Tonći Galić <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phoenix 1.7 has deprecated Phoenix.View in favor
of Phoenix.Component and moved the get_flash
function out of controllers, making us call it
directly
This is an addendum to #1224