Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[accountingservice] add attributes to kafka spans #1286

Merged
merged 2 commits into from
Dec 4, 2023
Merged

[accountingservice] add attributes to kafka spans #1286

merged 2 commits into from
Dec 4, 2023

Conversation

puckpuck
Copy link
Contributor

@puckpuck puckpuck commented Dec 3, 2023

Changes

Add attributes to manually instrumented Kafka spans to bring them into parity with what we get auto-instrumented from Java.

Merge Requirements

  • CHANGELOG.md updated to document new feature additions

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

Signed-off-by: Pierre Tessier <[email protected]>
@puckpuck puckpuck requested a review from a team December 3, 2023 21:49
Signed-off-by: Pierre Tessier <[email protected]>
@julianocosta89 julianocosta89 merged commit 0244786 into open-telemetry:main Dec 4, 2023
27 checks passed
@puckpuck puckpuck deleted the accounting.kafka-span-attributes branch December 4, 2023 14:12
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
* add attributes to kafka spans

Signed-off-by: Pierre Tessier <[email protected]>

* add attributes to kafka spans

Signed-off-by: Pierre Tessier <[email protected]>

---------

Signed-off-by: Pierre Tessier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants