Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend + adservice] Pass Session ID through baggage #1502

Merged

Conversation

austinlparker
Copy link
Member

Changes

Adds the session ID to the baggage when calling adservice in order to consume it in feature flag context.

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@austinlparker austinlparker requested a review from a team April 6, 2024 16:29
Copy link
Contributor

@puckpuck puckpuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update utils/enums/AttributeNames.ts to use the semantic convention standard of session.id instead of with the app prefix.

src/adservice/src/main/java/oteldemo/AdService.java Outdated Show resolved Hide resolved
src/frontend/gateways/Api.gateway.ts Outdated Show resolved Hide resolved
@puckpuck puckpuck linked an issue Apr 7, 2024 that may be closed by this pull request
@austinlparker austinlparker merged commit fb75872 into open-telemetry:main Apr 14, 2024
27 checks passed
@austinlparker austinlparker deleted the passSessionIdAsBaggage branch April 14, 2024 01:07
AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this pull request Jul 10, 2024
…y#1502)

* pass session ID as baggage to adservice

* address review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Session ID to Baggage
2 participants