Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kafka permission in dockerfile #1574

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

zzh8829
Copy link
Contributor

@zzh8829 zzh8829 commented May 14, 2024

Changes

Before the fix, kafka will crash immediate when running in docker compose on m1 mac, unsure if this also happens in other environments or platform.

How to reproduce the issue

docker compose up --no-deps --build kafka

logs

kafka  | Error opening zip file or JAR manifest missing : /tmp/opentelemetry-javaagent.jar Error occurred during initialization of VM agent library failed Agent_OnLoad: instrument
kafka exited with code 1

inspecting the jar showing incorrect permission

/ $ ls -al /tmp/opentelemetry-javaagent.jar 
-rw-------    1 root     root      21007939 Apr 12 00:45 /tmp/opentelemetry-javaagent.jar

after the fix

/ $ ls -al /tmp/opentelemetry-javaagent.jar 
-rw-------    1 appuser  appuser   21007939 Apr 12 00:45 /tmp/opentelemetry-javaagent.jar

Merge Requirements

For new features contributions please make sure you have completed the following
essential items:

  • CHANGELOG.md updated to document new feature additions
  • Appropriate documentation updates in the docs
  • Appropriate Helm chart updates in the helm-charts

Maintainers will not merge until the above have been completed. If you're unsure
which docs need to be changed ping the
@open-telemetry/demo-approvers.

@zzh8829 zzh8829 requested a review from a team May 14, 2024 21:49
@puckpuck puckpuck added the helm-update-required Requires an update to the Helm chart when released label May 15, 2024
@topaztee
Copy link

thanks this solution worked for me 👍

Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works in a Linux environment too

@puckpuck puckpuck merged commit e91611b into open-telemetry:main Jun 1, 2024
30 checks passed
AlexPSplunk pushed a commit to splunk/edu-opentelemetry-demo that referenced this pull request Jul 10, 2024
* Fix kafka permission in dockerfile

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm-update-required Requires an update to the Helm chart when released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants