Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[recommendation] - add manual tracing instrumentation #163

Conversation

puckpuck
Copy link
Contributor

Fixes #59

  • Services extend automatic instrumentation.
    • New attributes/events attached to existing spans.
    • New spans are being created from existing spans.

Changes

Adds an attribute to the auto-instrumented span, and moves logic to get the list of products to a new function wrapped in a new span with attributes.

@puckpuck puckpuck requested a review from a team June 23, 2022 02:15
Copy link
Contributor

@mic-max mic-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cartersocha cartersocha merged commit 83c5d43 into open-telemetry:main Jul 2, 2022
@puckpuck puckpuck deleted the puckpuck.recommendation-manual-instrumentation branch August 3, 2022 22:55
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
…#163)

* add manual spans and attributes

* fix Check function args

* Update src/recommendationservice/recommendation_server.py

Co-authored-by: Michael Maxwell <[email protected]>

Co-authored-by: Michael Maxwell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and enhance tracing support for recommendation service (Python)
4 participants