Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling java agent from the Java instrumentation releases instead. #253

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Pulling java agent from the Java instrumentation releases instead. #253

merged 3 commits into from
Aug 3, 2022

Conversation

JaredTan95
Copy link
Member

@JaredTan95 JaredTan95 commented Aug 3, 2022

Signed-off-by: jian.tan [email protected]

Fixes #244 (comment)

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #

Signed-off-by: jian.tan <[email protected]>
@JaredTan95 JaredTan95 requested a review from a team August 3, 2022 04:53
Copy link
Member

@julianocosta89 julianocosta89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@cartersocha
Copy link
Contributor

Should we remove the agent from our repo as well or is it a backup? Seems like the local copy is still there but not referenced

@mviitane
Copy link
Member

mviitane commented Aug 3, 2022

Should we remove the agent from our repo as well or is it a backup? Seems like the local copy is still there but not referenced

The agent file seems to be removed, see the third change.

@cartersocha
Copy link
Contributor

Should we remove the agent from our repo as well or is it a backup? Seems like the local copy is still there but not referenced

The agent file seems to be removed, see the third change.

ahh that’ll teach me to not do pr reviews on the GitHub app! Lgtm

@cartersocha cartersocha merged commit aad6e02 into open-telemetry:main Aug 3, 2022
@JaredTan95 JaredTan95 deleted the pull_agent_jar_from_release branch August 3, 2022 06:41
jmichalak9 pushed a commit to jmichalak9/opentelemetry-demo that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants