Bump OTel to 1.4.0 #1038

Kielek · 2023-02-24T10:29:40Z

Changes

Bump OTel 1.4.0 together with non-Core packages.
Exporter.Instana was pinned to 1.3.2. For now it is referencing net4.6.1
Adjust tests.
Tests executed only against netcoreapp3.1 are executed also on net7.0 and net6.0 (projects referencing OTel 1.4.0).

For significant contributions please make sure you have completed the following items:

Appropriate CHANGELOG.md updated for non-trivial changes
~~[ ] Design discussion issue #~~
~~[ ] Changes in public API reviewed~~

…oreapp3.1

Previously Sdk.CreateTracerProviderBuilder was returning instance not inheriting byIDeferredTracerProviderBuilder

src/OpenTelemetry.Exporter.Instana/OpenTelemetry.Exporter.Instana.csproj

codecov · 2023-02-24T10:46:42Z

Codecov Report

Merging #1038 (3d677e5) into main (1c7fd9a) will decrease coverage by 0.04%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   69.44%   69.40%   -0.04%     
==========================================
  Files         202      202              
  Lines        7668     7668              
==========================================
- Hits         5325     5322       -3     
- Misses       2343     2346       +3

Impacted Files	Coverage Δ
...ourceDetectors.Azure/AppServiceResourceDetector.cs	`87.50% <ø> (ø)`
...ckExchangeRedis/TracerProviderBuilderExtensions.cs	`88.46% <0.00%> (-11.54%)`	⬇️

cijothomas · 2023-02-27T18:31:40Z

Drop netcoreapp3.1 tests for projects based on OpenTelemetryCoreLatestVersion (to avoid compilation warnings)

^ We need to either revert this part, OR work-around the compiler warning, OR Get explicit approval from the component owners before merge.

utpilla · 2023-02-27T18:50:05Z

src/OpenTelemetry.Contrib.Instrumentation.AWS/README.md

@@ -17,7 +17,7 @@ using OpenTelemetry.Trace;
 public void ConfigureServices(IServiceCollection services)
 {
 services.AddControllers();
- services.AddOpenTelemetryTracing((builder) => builder
+ services.AddOpenTelemetry().WithTracing(builder => builder


I don't think if we should simply update the README with the new methods.

It could be the case that a lot of the users of AWS instrumentation still use older version of OTel and the extensions hosting package (considering this project still references OTel SDK 1.0.1)

I will revert this file. Other redmes looks good

Kielek · 2023-02-27T18:53:14Z

Drop netcoreapp3.1 tests for projects based on OpenTelemetryCoreLatestVersion (to avoid compilation warnings)

^ We need to either revert this part, OR work-around the compiler warning, OR Get explicit approval from the component owners before merge.

I will check the workaround. As I remember there is some switch for it. Give me around one hour

src/OpenTelemetry.Instrumentation.StackExchangeRedis/CHANGELOG.md

Kielek · 2023-02-27T19:18:30Z

Drop netcoreapp3.1 tests for projects based on OpenTelemetryCoreLatestVersion (to avoid compilation warnings)

^ We need to either revert this part, OR work-around the compiler warning, OR Get explicit approval from the component owners before merge.

Fixed in 2ada9f6.
~~CI is still running.~~

Tests are failing for EventCournters for netcoreapp3.1, but I think it is expected per: open-telemetry/opentelemetry-dotnet#3767 (reply in thread) (test relay on metrics)

Removing it from pipeilene: 3d677e5

@hananiel, @mic-max could you please check if you are fine with this change?

mic-max

LGTM wrt EventCounters 👍

Kielek added 10 commits February 24, 2023 07:40

Switch packages to 1.4.0-rc.4

c407ab1

OpenTelemetry.Extensions.Hosting is versioned with other Core packages

206ed5f

Bump OpenTelemetry.Instrumentation.Http to 1.0.0-rc9.13

7debf22

Handle lack of reference to System.Reflection.Emit.Lightweight in OTel

efb9e28

Upgrade other OTel packages

47a56b4

[AzureDetector] Fix CS8766

68eeab7

Handle Obsolete AddOpenTelemetryTracing

89a5d3f

Fix System.Memory redirect warning

f3f2590

Handle System.Diagnostics.DiagnosticSource 7.0.0 doesn't support netc…

c560fd9

…oreapp3.1

Fix RedisTest

31caadf

Previously Sdk.CreateTracerProviderBuilder was returning instance not inheriting byIDeferredTracerProviderBuilder

Kielek force-pushed the bump-otel-1.4.0 branch from 8acfce4 to 6dc7921 Compare February 24, 2023 10:30

CHANGELOGs

f2a8a19

Kielek force-pushed the bump-otel-1.4.0 branch from 6dc7921 to f2a8a19 Compare February 24, 2023 10:32

pellared approved these changes Feb 24, 2023

View reviewed changes

src/OpenTelemetry.Exporter.Instana/OpenTelemetry.Exporter.Instana.csproj Show resolved Hide resolved

Kielek mentioned this pull request Feb 24, 2023

Upgrade to OTel 1.4.0 open-telemetry/opentelemetry-dotnet-instrumentation#1671

Closed

Kielek added dependencies Pull requests that update a dependency file .NET labels Feb 24, 2023

Kielek added 2 commits February 27, 2023 07:02

Merge branch 'main' into bump-otel-1.4.0

4ae50e8

Update packages to 1.4.0/1.0.0-rc9.14

ff4d916

Kielek changed the title ~~[WIP] Bump OTel to 1.4.0~~ Bump OTel to 1.4.0 Feb 27, 2023

Kielek marked this pull request as ready for review February 27, 2023 06:25

Kielek requested a review from a team February 27, 2023 06:25

Kielek mentioned this pull request Feb 27, 2023

Update the latest OTel stable version to 1.4.0 #1042

Closed

pellared approved these changes Feb 27, 2023

View reviewed changes

Merge branch 'main' into bump-otel-1.4.0

6c1f2ac

github-actions bot assigned cijothomas, CodeBlanch, hananiel and mic-max Feb 27, 2023

github-actions bot assigned rajkumar-rangaraj, reyang, SergeyKanzhelev, srprash, utpilla and vishweshbankwar Feb 27, 2023

cijothomas approved these changes Feb 27, 2023

View reviewed changes

utpilla reviewed Feb 27, 2023

View reviewed changes

vishweshbankwar reviewed Feb 27, 2023

View reviewed changes

src/OpenTelemetry.Instrumentation.StackExchangeRedis/CHANGELOG.md Outdated Show resolved Hide resolved

Kielek added 2 commits February 27, 2023 20:03

link fix

94c52e5

Revert AWS readme, as it is using old version of OTel

834f467

vishweshbankwar reviewed Feb 27, 2023

View reviewed changes

src/OpenTelemetry.Instrumentation.StackExchangeRedis/CHANGELOG.md Show resolved Hide resolved

Kielek added 2 commits February 27, 2023 20:10

Bring back netcoreapp3.1 for tests

2ada9f6

Shared project uses $(OpenTelemetryCoreLatestVersion)

4eb59e1

Remove netcoreapp3.1 from EventCounter Tests

3d677e5

Kielek requested review from mic-max and hananiel February 27, 2023 19:27

cijothomas approved these changes Feb 27, 2023

View reviewed changes

utpilla approved these changes Feb 27, 2023

View reviewed changes

utpilla merged commit 3ca2b34 into open-telemetry:main Feb 27, 2023

mic-max reviewed Feb 27, 2023

View reviewed changes

Kielek mentioned this pull request Feb 28, 2023

[Exporter.Instana] Bump OTel to 1.4.0 #1050

Merged

1 task

utpilla mentioned this pull request Mar 10, 2023

[Exporter.Geneva] Update GenevaMetricExporter to export Exemplars #1069

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump OTel to 1.4.0 #1038

Bump OTel to 1.4.0 #1038

Kielek commented Feb 24, 2023 •

edited

Loading

codecov bot commented Feb 24, 2023 •

edited

Loading

cijothomas commented Feb 27, 2023

utpilla Feb 27, 2023 •

edited

Loading

Kielek Feb 27, 2023

Kielek Feb 27, 2023

Kielek commented Feb 27, 2023

Kielek commented Feb 27, 2023 •

edited

Loading

mic-max left a comment

Bump OTel to 1.4.0 #1038

Bump OTel to 1.4.0 #1038

Conversation

Kielek commented Feb 24, 2023 • edited Loading

Changes

codecov bot commented Feb 24, 2023 • edited Loading

Codecov Report

cijothomas commented Feb 27, 2023

utpilla Feb 27, 2023 • edited Loading

Choose a reason for hiding this comment

Kielek Feb 27, 2023

Choose a reason for hiding this comment

Kielek Feb 27, 2023

Choose a reason for hiding this comment

Kielek commented Feb 27, 2023

Kielek commented Feb 27, 2023 • edited Loading

mic-max left a comment

Choose a reason for hiding this comment

Kielek commented Feb 24, 2023 •

edited

Loading

codecov bot commented Feb 24, 2023 •

edited

Loading

utpilla Feb 27, 2023 •

edited

Loading

Kielek commented Feb 27, 2023 •

edited

Loading