Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OpenTelemetry to 1.5.0 #1220

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Jun 6, 2023

Fixes N/A

Changes

Bumps OpenTelemetry API/SDK for most packages.
Exceptions, should be handled separately:

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • [ ] Design discussion issue #
  • [ ] Changes in public API reviewed

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1220 (90a2d96) into main (18b0b03) will increase coverage by 0.89%.
The diff coverage is 96.53%.

❗ Current head 90a2d96 differs from pull request most recent head 4247d17. Consider uploading reports for the commit 4247d17 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
+ Coverage   73.17%   74.06%   +0.89%     
==========================================
  Files         260      266       +6     
  Lines        9133     9340     +207     
==========================================
+ Hits         6683     6918     +235     
+ Misses       2450     2422      -28     
Impacted Files Coverage Δ
...orter.Geneva/MsgPackExporter/MsgPackLogExporter.cs 93.33% <ø> (ø)
...etry.Exporter.Geneva/TLDExporter/TldLogExporter.cs 37.11% <ø> (ø)
src/OpenTelemetry.Sampler.AWS/Clock.cs 100.00% <ø> (ø)
....Exporter.Geneva/GenevaExporterHelperExtensions.cs 61.11% <71.42%> (+5.55%) ⬆️
...rs.AWS/Http/ServerCertificateValidationProvider.cs 59.67% <80.00%> (+0.30%) ⬆️
src/OpenTelemetry.Sampler.AWS/FallbackSampler.cs 88.88% <83.33%> (-11.12%) ⬇️
.../OpenTelemetry.Sampler.AWS/AWSXRayRemoteSampler.cs 82.60% <91.30%> (+10.86%) ⬆️
src/OpenTelemetry.Sampler.AWS/RulesCache.cs 90.90% <96.00%> (+17.83%) ⬆️
...xporter.Geneva/Internal/ConnectionStringBuilder.cs 92.94% <100.00%> (+0.25%) ⬆️
...r.Geneva/Metrics/GenevaMetricExporterExtensions.cs 100.00% <100.00%> (+10.00%) ⬆️
... and 13 more

... and 4 files with indirect coverage changes

@Kielek Kielek marked this pull request as ready for review June 6, 2023 08:11
@Kielek Kielek requested a review from a team June 6, 2023 08:11
@Kielek Kielek added the dependencies Pull requests that update a dependency file label Jun 6, 2023
@@ -84,7 +84,7 @@
<PackageReference Include="OpenTelemetry.Exporter.Console" Version="$(OpenTelemetryCoreLatestVersion)" />
<PackageReference Include="OpenTelemetry.Exporter.OpenTelemetryProtocol" Version="$(OpenTelemetryCoreLatestVersion)" />
<PackageReference Include="OpenTelemetry.Exporter.Zipkin" Version="$(OpenTelemetryCoreLatestVersion)" />
<PackageReference Include="OpenTelemetry.Exporter.Prometheus.HttpListener" Version="1.4.0-rc.4" />
<PackageReference Include="OpenTelemetry.Exporter.Prometheus.HttpListener" Version="1.5.0-rc.1" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is updated in multiple files. It would be good to extract this into a property in Common.props.

@utpilla utpilla merged commit e0d9e1e into open-telemetry:main Jun 6, 2023
@Kielek Kielek deleted the bump-otel-1.5.0 branch June 7, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.