Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OneCollectorExporter] Failed transmission callback #1309

Merged

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Aug 15, 2023

Changes

  • Extends the transmission callback mechanism so users can opt into receiving failed transmissions

TODOs

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Changes in public API reviewed

@CodeBlanch CodeBlanch requested a review from a team August 15, 2023 23:44
@github-actions github-actions bot requested a review from reyang August 15, 2023 23:44
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #1309 (30cd7db) into main (58607b7) will increase coverage by 0.25%.
The diff coverage is 100.00%.

❗ Current head 30cd7db differs from pull request most recent head 15e5a4c. Consider uploading reports for the commit 15e5a4c to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1309      +/-   ##
==========================================
+ Coverage   74.27%   74.53%   +0.25%     
==========================================
  Files         262      262              
  Lines        9490     9524      +34     
==========================================
+ Hits         7049     7099      +50     
+ Misses       2441     2425      -16     
Files Changed Coverage Δ
...ector/Internal/Transports/HttpJsonPostTransport.cs 95.41% <100.00%> (+13.41%) ⬆️
...etry.Exporter.OneCollector/OneCollectorExporter.cs 55.00% <100.00%> (+2.36%) ⬆️
...ctorExporterPayloadTransmittedCallbackArguments.cs 94.44% <100.00%> (+0.69%) ⬆️

... and 1 file with indirect coverage changes

@Kielek Kielek added the comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector label Aug 21, 2023
Copy link
Contributor

@utpilla utpilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

@CodeBlanch CodeBlanch merged commit fc4dc0d into open-telemetry:main Aug 24, 2023
20 of 21 checks passed
@CodeBlanch CodeBlanch deleted the onecollector-failuretransmissions branch August 24, 2023 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.onecollector Things related to OpenTelemetry.Exporter.OneCollector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants