Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Extensions.AWS] Remove NuGet reference to System.Net.Http #1713

Merged

Conversation

wjrogers
Copy link
Contributor

@wjrogers wjrogers commented May 9, 2024

Changes

Remove the reference to System.Net.Http to reduce noise in the NuGet dependency graph.

Including this reference requires restoring all these packages during builds. Most of them are stubs that don't contain binaries. They are not required on any of the supported .NET runtimes. (In fact, this project doesn't reference anything from the System.Net.Http namespace.)

"System.Net.Http": {
  "type": "Transitive",
  "resolved": "4.3.4",
  "contentHash": "aOa2d51SEbmM+H+Csw7yJOuNZoHkrP2XnAurye5HWYgGVVU54YZDvsLUYRv6h18X3sPnjNCANmN7ZhIPiqMcjA==",
  "dependencies": {
    "Microsoft.NETCore.Platforms": "1.1.1",
    "System.Collections": "4.3.0",
    "System.Diagnostics.Debug": "4.3.0",
    "System.Diagnostics.DiagnosticSource": "4.3.0",
    "System.Diagnostics.Tracing": "4.3.0",
    "System.Globalization": "4.3.0",
    "System.Globalization.Extensions": "4.3.0",
    "System.IO": "4.3.0",
    "System.IO.FileSystem": "4.3.0",
    "System.Net.Primitives": "4.3.0",
    "System.Resources.ResourceManager": "4.3.0",
    "System.Runtime": "4.3.0",
    "System.Runtime.Extensions": "4.3.0",
    "System.Runtime.Handles": "4.3.0",
    "System.Runtime.InteropServices": "4.3.0",
    "System.Security.Cryptography.Algorithms": "4.3.0",
    "System.Security.Cryptography.Encoding": "4.3.0",
    "System.Security.Cryptography.OpenSsl": "4.3.0",
    "System.Security.Cryptography.Primitives": "4.3.0",
    "System.Security.Cryptography.X509Certificates": "4.3.0",
    "System.Text.Encoding": "4.3.0",
    "System.Threading": "4.3.0",
    "System.Threading.Tasks": "4.3.0",
    "runtime.native.System": "4.3.0",
    "runtime.native.System.Net.Http": "4.3.0",
    "runtime.native.System.Security.Cryptography.OpenSsl": "4.3.2"
  }
}

@wjrogers wjrogers marked this pull request as ready for review May 9, 2024 18:12
@wjrogers wjrogers requested a review from a team May 9, 2024 18:12
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.17%. Comparing base (71655ce) to head (8fff980).
Report is 230 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1713      +/-   ##
==========================================
+ Coverage   73.91%   80.17%   +6.25%     
==========================================
  Files         267      116     -151     
  Lines        9615     3077    -6538     
==========================================
- Hits         7107     2467    -4640     
+ Misses       2508      610    -1898     
Flag Coverage Δ
unittests-Solution 80.17% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 255 files with indirect coverage changes

@cijothomas
Copy link
Member

Tagging owners : @srprash @atshaw43 @ppittle Please review!

@cijothomas
Copy link
Member

@Kielek Kielek added the comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS label May 9, 2024
@Kielek
Copy link
Contributor

Kielek commented May 10, 2024

https:/open-telemetry/opentelemetry-dotnet-contrib/actions/runs/9021608738/job/24789303314?pr=1713#step:2:10 The workflow is broken it seems.

I think the problem is with definition of who is the "collaborator" by the GitHub. I didn't find a way to mark all codeowners as collaborators. I suppose we could change the assign job, to call all code-owners in the comments. It should be always working.

@Kielek Kielek merged commit 0eb824d into open-telemetry:main May 10, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:extensions.aws Things related to OpenTelemetry.Extensions.AWS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants