Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Exporter.Geneva] Add LoggerProviderBuilder extensions #1880

Conversation

vishweshbankwar
Copy link
Member

@vishweshbankwar vishweshbankwar commented Jun 11, 2024

Fixes #.

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • Appropriate CHANGELOG.md updated for non-trivial changes
  • Design discussion issue #
  • Changes in public API reviewed

@vishweshbankwar vishweshbankwar added the comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva label Jun 11, 2024
Copy link

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 98.96907% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.81%. Comparing base (71655ce) to head (2462092).
Report is 300 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1880      +/-   ##
==========================================
- Coverage   73.91%   64.81%   -9.11%     
==========================================
  Files         267       35     -232     
  Lines        9615     3646    -5969     
==========================================
- Hits         7107     2363    -4744     
+ Misses       2508     1283    -1225     
Flag Coverage Δ
unittests-Exporter.Geneva 64.81% <98.96%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
....Exporter.Geneva/GenevaExporterHelperExtensions.cs 100.00% <100.00%> (+31.81%) ⬆️
...lemetry.Exporter.Geneva/GenevaLoggingExtensions.cs 98.36% <98.14%> (+12.64%) ⬆️

... and 247 files with indirect coverage changes

@vishweshbankwar vishweshbankwar marked this pull request as ready for review June 12, 2024 00:22
@vishweshbankwar vishweshbankwar requested a review from a team June 12, 2024 00:22
Copy link
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vishweshbankwar vishweshbankwar merged commit cd7e8d3 into open-telemetry:main Jun 12, 2024
57 checks passed
@CodeBlanch
Copy link
Member

Adding link: #613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:exporter.geneva Things related to OpenTelemetry.Exporter.Geneva
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants