Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Elastic.Clients.Elasticsearch traces instrumentation 8.10.0+ #2989

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 5, 2023

Bumps Elastic.Clients.Elasticsearch from 8.9.3 to 8.10.0.

Release notes

Sourced from Elastic.Clients.Elasticsearch's releases.

8.10.0

elastic/elasticsearch-net@8.9.3...8.10.0

Features & Enhancements

  • #7931 Refactor OpenTelemetry implementation with updated Transport (issue: #7885)

Bug fixes

View the full list of issues and PRs

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [Elastic.Clients.Elasticsearch](https:/elastic/elasticsearch-net) from 8.9.3 to 8.10.0.
- [Release notes](https:/elastic/elasticsearch-net/releases)
- [Changelog](https:/elastic/elasticsearch-net/blob/main/CHANGELOG.md)
- [Commits](elastic/elasticsearch-net@8.9.3...8.10.0)

---
updated-dependencies:
- dependency-name: Elastic.Clients.Elasticsearch
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team October 5, 2023 12:28
@dependabot dependabot bot added .NET Pull requests that update .net code dependencies labels Oct 5, 2023
@Kielek Kielek enabled auto-merge (squash) October 5, 2023 18:06
@Kielek Kielek disabled auto-merge October 6, 2023 06:00
@Kielek Kielek changed the title Bump Elastic.Clients.Elasticsearch from 8.9.3 to 8.10.0 Support Elastic.Clients.Elasticsearch traces instrumentation 8.10.0+ Oct 6, 2023
@Kielek
Copy link
Contributor

Kielek commented Oct 6, 2023

8.10.0 introduces breaking change in ActivitySource.
It was Elastic.Clients.Elasticsearch.ElasticsearchClient. Now it is Elastic.Transport (in child library).
Ref: elastic/elastic-transport-net#100 and elastic/elastic-transport-net#92.

@stevejgordon, do you have more plans to change/extend OpenTelemetry in you .NET library clients? Should we adapt for more activity sources?

@stevejgordon
Copy link

@Kielek We made this change to ensure that all future clients get richer OTel integration from the outset when built on top of Elastic.Transport. We don't plan to change the ActivitySource name going forward or introduce other sources. We expect that our instrumentation is now stable after this refactoring.

@Kielek
Copy link
Contributor

Kielek commented Oct 6, 2023

@stevejgordon, thanks for the information.

@open-telemetry/dotnet-instrumentation-approvers, I am considering to add one more separate instrumentation
ELASTICTRANSPORT and document it separately. as currently in fact we instrumenting https://www.nuget.org/packages/Elastic.Transport#usedby-body-tab which in fact supports more libraries.
Testing library can stay the same.

Please let me know what do you think.

@pjanotti pjanotti enabled auto-merge (squash) October 6, 2023 15:59
@pjanotti pjanotti merged commit 67681b9 into main Oct 6, 2023
29 checks passed
@pjanotti pjanotti deleted the dependabot/nuget/Elastic.Clients.Elasticsearch-8.10.0 branch October 6, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants