Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTracing shim constructor doesn't match spec #4727

Closed
pjanotti opened this issue Jul 28, 2023 · 0 comments · Fixed by #4812
Closed

OpenTracing shim constructor doesn't match spec #4727

pjanotti opened this issue Jul 28, 2023 · 0 comments · Fixed by #4812
Labels
bug Something isn't working

Comments

@pjanotti
Copy link
Contributor

Per spec, the operation to create the OpenTracing Tracer shim should receive a TracerProvider and use it to create a Tracer with the name opentracing-shim. Currently, it receives a Tracer and lets the user select the name of the Tracer:

var tracer = new TracerShim(
TracerProvider.Default.GetTracer("MyCompany.MyProduct.MyWebServer"),
Propagators.DefaultTextMapPropagator);

Of course, removing the current constructor will be a breaking change. Since no stable versions of the OT shim package were released so far it seems that this should be done rather soon. The current constructor could be marked as obsolete for one or two releases before removing it completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant