[SelfDiagnosticsModule] Write event to log file in a circular way in … #1418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EventListener.OnEventWritten
Codecov Report
@@ Coverage Diff @@
## master #1418 +/- ##
==========================================
+ Coverage 81.72% 81.88% +0.15%
==========================================
Files 229 229
Lines 6095 6143 +48
==========================================
+ Hits 4981 5030 +49
+ Misses 1114 1113 -1
|
CodeBlanch
reviewed
Oct 31, 2020
CodeBlanch
reviewed
Oct 31, 2020
CodeBlanch
reviewed
Oct 31, 2020
reyang
reviewed
Nov 4, 2020
| return position; | ||
| } | ||
|
|
||
| internal void WriteEvent(string eventMessage, ReadOnlyCollection<object> payload) |
There was a problem hiding this comment.
Would IReadOnlyCollection work? https://docs.microsoft.com/en-us/dotnet/api/system.collections.generic.ireadonlycollection-1?view=netcore-3.1
There was a problem hiding this comment.
Yes, it would work. ReadOnlyCollection implements a bunch of interfaces including IReadOnlyCollection.
I used ReadOnlyCollection because it's the type of the EventWrittenEventArgs.Payload Property. Should I prioritize interfaces over base classes in definition of methods?
eddynaka
approved these changes
Nov 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…EventListener.OnEventWritten
Provide implementation for classes for step#4 in Implementation Plan section of #1258.
Changes
Write event to log file in a circular way in SelfDiagnosticsEventListener.OnEventWritten.