Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddOpenTelemetrySelfDiagnosticsLogging to OpenTelemetry.Extensions.Hosting #1867

Closed
wants to merge 14 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build/Common.nonprod.props
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
<SwashbuckleAspNetCorePkgVer>[5.0.0]</SwashbuckleAspNetCorePkgVer>
<XUnitRunnerVisualStudioPkgVer>[2.4.3,3.0)</XUnitRunnerVisualStudioPkgVer>
<XUnitPkgVer>[2.4.1,3.0)</XUnitPkgVer>
<FoundatioXUnitPkgVer>[10.0.2,11.0)</FoundatioXUnitPkgVer>
</PropertyGroup>

<ItemGroup>
Expand Down
4 changes: 4 additions & 0 deletions examples/AspNetCore/Startup.cs
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ public void ConfigureServices(IServiceCollection services)
{
case "jaeger":
services.AddOpenTelemetryTracing((builder) => builder
.AddSelfDiagnosticsLogging()
.SetResourceBuilder(ResourceBuilder.CreateDefault().AddService(this.Configuration.GetValue<string>("Jaeger:ServiceName")))
.AddAspNetCoreInstrumentation()
.AddHttpClientInstrumentation()
Expand All @@ -77,6 +78,7 @@ public void ConfigureServices(IServiceCollection services)
break;
case "zipkin":
services.AddOpenTelemetryTracing((builder) => builder
.AddSelfDiagnosticsLogging()
.SetResourceBuilder(ResourceBuilder.CreateDefault().AddService(this.Configuration.GetValue<string>("Zipkin:ServiceName")))
.AddAspNetCoreInstrumentation()
.AddHttpClientInstrumentation()
Expand All @@ -91,6 +93,7 @@ public void ConfigureServices(IServiceCollection services)
AppContext.SetSwitch("System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport", true);

services.AddOpenTelemetryTracing((builder) => builder
.AddSelfDiagnosticsLogging()
.SetResourceBuilder(ResourceBuilder.CreateDefault().AddService(this.Configuration.GetValue<string>("Otlp:ServiceName")))
.AddAspNetCoreInstrumentation()
.AddHttpClientInstrumentation()
Expand All @@ -101,6 +104,7 @@ public void ConfigureServices(IServiceCollection services)
break;
default:
services.AddOpenTelemetryTracing((builder) => builder
.AddSelfDiagnosticsLogging()
.AddAspNetCoreInstrumentation()
.AddHttpClientInstrumentation()
.AddConsoleExporter());
Expand Down
1 change: 1 addition & 0 deletions examples/AspNetCore/appsettings.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"Logging": {
"LogLevel": {
"Default": "Information",
"OpenTelemetry": "Trace",
"Microsoft": "Warning",
"Microsoft.Hosting.Lifetime": "Information"
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ static OpenTelemetry.Metrics.MeterProviderBuilderExtensions.Configure(this OpenT
static OpenTelemetry.Metrics.MeterProviderBuilderExtensions.GetServices(this OpenTelemetry.Metrics.MeterProviderBuilder meterProviderBuilder) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
static OpenTelemetry.Trace.TracerProviderBuilderExtensions.AddInstrumentation<T>(this OpenTelemetry.Trace.TracerProviderBuilder tracerProviderBuilder) -> OpenTelemetry.Trace.TracerProviderBuilder
static OpenTelemetry.Trace.TracerProviderBuilderExtensions.AddProcessor<T>(this OpenTelemetry.Trace.TracerProviderBuilder tracerProviderBuilder) -> OpenTelemetry.Trace.TracerProviderBuilder
static OpenTelemetry.Trace.TracerProviderBuilderExtensions.AddSelfDiagnosticsLogging(this OpenTelemetry.Trace.TracerProviderBuilder tracerProviderBuilder) -> OpenTelemetry.Trace.TracerProviderBuilder
static OpenTelemetry.Trace.TracerProviderBuilderExtensions.Build(this OpenTelemetry.Trace.TracerProviderBuilder tracerProviderBuilder, System.IServiceProvider serviceProvider) -> OpenTelemetry.Trace.TracerProvider
static OpenTelemetry.Trace.TracerProviderBuilderExtensions.Configure(this OpenTelemetry.Trace.TracerProviderBuilder tracerProviderBuilder, System.Action<System.IServiceProvider, OpenTelemetry.Trace.TracerProviderBuilder> configure) -> OpenTelemetry.Trace.TracerProviderBuilder
static OpenTelemetry.Trace.TracerProviderBuilderExtensions.GetServices(this OpenTelemetry.Trace.TracerProviderBuilder tracerProviderBuilder) -> Microsoft.Extensions.DependencyInjection.IServiceCollection
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,111 @@
// <copyright file="EventSourceEventFormatter.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.
// </copyright>

using System;
using System.Diagnostics.Tracing;
using System.Globalization;
using System.Linq;

namespace OpenTelemetry.Internal
{
internal static class EventSourceEventFormatter
{
private static readonly object[] EmptyPayload = Array.Empty<object>();

public static string Format(EventWrittenEventArgs eventData)
{
if (eventData == null)
{
return string.Empty;
}

var payloadCollection = eventData.Payload?.ToArray() ?? EmptyPayload;

ProcessPayloadArray(payloadCollection);

if (eventData.Message != null)
{
try
{
return string.Format(CultureInfo.InvariantCulture, eventData.Message, payloadCollection);
}
catch (FormatException)
{
}
}

var stringBuilder = StringBuilderPool.Instance.Get();

try
{
stringBuilder.Append(eventData.EventName);

if (!string.IsNullOrWhiteSpace(eventData.Message))
{
stringBuilder.AppendLine();
stringBuilder.Append(nameof(eventData.Message)).Append(" = ").Append(eventData.Message);
}

if (eventData.PayloadNames != null)
{
for (int i = 0; i < eventData.PayloadNames.Count; i++)
{
stringBuilder.AppendLine();
stringBuilder.Append(eventData.PayloadNames[i]).Append(" = ").Append(payloadCollection[i]);
}
}

return stringBuilder.ToString();
}
finally
{
StringBuilderPool.Instance.Return(stringBuilder);
}
}

private static void ProcessPayloadArray(object[] payloadArray)
{
for (int i = 0; i < payloadArray.Length; i++)
{
payloadArray[i] = FormatValue(payloadArray[i]);
}
}

private static object FormatValue(object o)
{
if (o is byte[] bytes)
{
var stringBuilder = StringBuilderPool.Instance.Get();

try
{
foreach (byte b in bytes)
{
stringBuilder.AppendFormat(CultureInfo.InvariantCulture, "{0:X2}", b);
}

return stringBuilder.ToString();
}
finally
{
StringBuilderPool.Instance.Return(stringBuilder);
}
}

return o;
}
}
}
Loading