Hosting: README documentation + tweaks #2080
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2080 +/- ##
==========================================
+ Coverage 82.12% 84.99% +2.87%
==========================================
Files 250 187 -63
Lines 6774 6071 -703
==========================================
- Hits 5563 5160 -403
+ Misses 1211 911 -300
|
| .AddAspNetCoreInstrumentation() | ||
| .AddHttpClientInstrumentation() | ||
| .AddZipkinExporter() | ||
| .AddMyFeature()); |
There was a problem hiding this comment.
Does this mean ZipkinExporter will run before MyProcessor?
There was a problem hiding this comment.
Does this mean ZipkinExporter will run before MyProcessor?
Yes.
I didn't think of this until right now, but this is a kind of interesting situation...
.AddMyFeature()
.AddProcessor(new CustomProcessor())In that case CustomProcessor will run before MyFeature's MyProcessor because MyFeature is using Configure which defers execution (AddProcessor call) until Build is called.
May or may not be an issue?
There was a problem hiding this comment.
PS: I switched the order in the README to make it more real-world.
There was a problem hiding this comment.
Not an issue in my opinion, but some folks might get shocked if they were expecting different behavior.
Basically we need to set the expectation that these are like TSRs and users should understand that ordering does matter.
Added documentation to the hosting README with usage examples. Tweaked some of the XML comments for clarity. Allowed configuration callbacks to be registered inside themselves. Fixed some bugs. And, best of all, simplified things.