[Metrics] Clean up repo exporters to use new DI patterns #3648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the metric exporters to use the new DI API surface.
Adds support for named options in metric exporter registrations.
The SdkSupportsMultipleReaders test exposed an issue with our pattern! We are doing
serviceProvider.GetRequiredService<IOptions<OptionsType>>()
everywhere. That is giving us (more or less) a global options instance (really what it does is just use the default name). Works fine when only a single exporter is registered, but if multiple are in play there be dragons. To solve this I added overloads where users can specify a name to control the options. Users who don't need this don't need to do anything they will just continue to use the default instance.TODOs