[sdk-logs] Introduce AddOpenTelemetryLogging ILoggingBuilder extension (proposal 2) #4501
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #4433
Relates to #4496
Changes
ILoggingBuilder.AddOpenTelemetryLogging
extension for configuringLoggerProviderBuilder
LoggerProviderBuilder.ConfigureLoggerOptions
extension for configuringOpenTelemetryLoggerOptions
Overview
This is a draft implementation of @noahfalk's comment: #4496 (comment)
I went with
AddOpenTelemetryLogging
instead ofSendToOpenTelemetry
because all of the ILoggingBuilder extensions today are named "AddThing" so it just seemed weird. But I'm open to naming it whatever.Details
Today we configure logging like this:
"options" is
OpenTelemetryLoggerOptions
class.Now the OpenTelemetry Specification has
LoggerProvider
and we have aLoggerProviderBuilder
API. The SDKLoggerProvider
is fed into theILogger
integration (OpenTelemetryLoggerProvider
).There are different ways we could approach this. Today we have extensions for logging that target
OpenTelemetryLoggerOptions
. We will need to targetLoggerProviderBuilder
now. We could forever have two versions of every extension, but that seems lame.This PR is adding a new extension
AddOpenTelemetryLogging
to try and bridge the two worlds.AddOpenTelemetry
extension andOpenTelemetryLoggerOptions.AddProcessor
andOpenTelemetryLoggerOptions.SetResourceBuilder
methods would be obsoleted as would our existing extensions onOpenTelemetryLoggerOptions
.All of these styles can be interchanged.
Merge requirement checklist