Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[inmemory-logs] Expose LoggerProviderBuilder extension #4584

Conversation

CodeBlanch
Copy link
Member

@CodeBlanch CodeBlanch commented Jun 12, 2023

Relates to #4433

Changes

  • Exposes the LoggerProviderBuilder.AddInMemoryExporter extension

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@CodeBlanch CodeBlanch requested a review from a team June 12, 2023 18:02
@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #4584 (d617576) into main (09399d8) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4584   +/-   ##
=======================================
  Coverage   85.12%   85.12%           
=======================================
  Files         320      320           
  Lines       12679    12679           
=======================================
  Hits        10793    10793           
  Misses       1886     1886           
Impacted Files Coverage Δ
...rter.InMemory/InMemoryExporterLoggingExtensions.cs 66.66% <ø> (ø)

... and 2 files with indirect coverage changes

@CodeBlanch CodeBlanch merged commit 04c7c08 into open-telemetry:main Jun 12, 2023
@CodeBlanch CodeBlanch deleted the inmemory-loggerproviderbuilderext-public branch June 12, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants