Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenTracing.Shim] Remove obsolete constructor #4862

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

Kielek
Copy link
Contributor

@Kielek Kielek commented Sep 18, 2023

Cleanup for #4812

Changes

Remove obsolete constructor from OpenTracing Shim.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated handled in previous PR.
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #4862 (135d8a9) into main (fe78453) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4862      +/-   ##
==========================================
+ Coverage   83.91%   83.93%   +0.02%     
==========================================
  Files         293      293              
  Lines       12028    12021       -7     
==========================================
- Hits        10093    10090       -3     
+ Misses       1935     1931       -4     
Files Changed Coverage
src/OpenTelemetry.Shims.OpenTracing/TracerShim.cs ø

@Kielek
Copy link
Contributor Author

Kielek commented Sep 18, 2023

Failed test OpenTelemetry.Exporter.Prometheus.Tests.PrometheusHttpListenerTests.PrometheusExporterHttpServerIntegration_NoMetrics on net462 not related to changes.

@Kielek Kielek marked this pull request as ready for review September 18, 2023 05:07
@Kielek Kielek requested a review from a team September 18, 2023 05:07
@Kielek
Copy link
Contributor Author

Kielek commented Sep 18, 2023

@pjanotti, FYI

Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@utpilla utpilla merged commit 2c5c034 into open-telemetry:main Sep 18, 2023
49 of 50 checks passed
@Kielek Kielek deleted the opentracing-shim-cleanup branch September 18, 2023 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants