-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk] Move OpenTelemetryBuilder to SDK and add OpenTelemetrySdk API #5137
[sdk] Move OpenTelemetryBuilder to SDK and add OpenTelemetrySdk API #5137
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5137 +/- ##
==========================================
- Coverage 83.38% 82.92% -0.46%
==========================================
Files 297 273 -24
Lines 12531 11995 -536
==========================================
- Hits 10449 9947 -502
+ Misses 2082 2048 -34
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Capturing the thoughts/concerns/questions raised from our discussion in last week's SIG meeting.
My personal thoughts: I support moving the I do not have major concerns about any confusion with multiple ways of configuring the OTLP exporter, but I think we need to discuss points 3-6 further. |
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
Relates to #4940
Changes
OpenTelemetryBuilder
fromOpenTelemetry.Extensions.Hosting
intoOpenTelemetry
(SDK).OpenTelemetrySdk
API.Details
We have a request from .NET Aspire team to add a cross-cutting
AddOtlpExporter
extension. I was able to make it work by defining an IOpenTelemetryBuilder interface in SDK and using some generic gymnastics on the extension method so the builder type is preserved but it kind of hack.What this PR does is move
OpenTelemetryBuilder
fully into the SDK so that extensions may target it directly.Taking that a step further I also defined an
OpenTelemetrySdk
API. What this API does is make sure our .NET Framework friends are not left behind and gives them a path to utilize cross-cutting things. It also has the benefit of potentially unifying our startup/configuration story/documentation so everything uses the same "With" style.New style:
Old style:
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial changes