Minor refactoring for instrumentation libraries #5162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utpilla
commented
Dec 12, 2023
| { | ||
| var context = payload as HttpContext; | ||
| if (context == null) | ||
| { | ||
| AspNetCoreInstrumentationEventSource.Log.NullPayload(nameof(HttpInMetricsListener), EventName, HttpServerRequestDurationMetricName); | ||
| AspNetCoreInstrumentationEventSource.Log.NullPayload(nameof(HttpInMetricsListener), nameof(OnStopEventWritten), HttpServerRequestDurationMetricName); |
There was a problem hiding this comment.
Updated this to log the name of the method instead.
vishweshbankwar
approved these changes
Dec 12, 2023
utpilla
commented
Dec 12, 2023
|
|
||
| public override void OnEventWritten(string name, object payload) | ||
| { | ||
| if (name == OnStopEvent) |
There was a problem hiding this comment.
I have changed the order of the if conditions. For the common case, we don't want to waste cycles doing a string match for the exception event first.
vishweshbankwar
approved these changes
Dec 12, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5162 +/- ##
==========================================
- Coverage 83.54% 83.48% -0.06%
==========================================
Files 297 297
Lines 12368 12367 -1
==========================================
- Hits 10333 10325 -8
- Misses 2035 2042 +7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes