-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: resource-detector
should not be tied to tracing
#5188
Changes from 6 commits
230ceef
a716387
02a4580
8b4d024
686ca71
fbd84b6
6ff7dce
a147131
99e1412
9630d17
4a13e6c
492593a
e784a10
a3d3c5d
cb4807e
22b8231
3edf8a7
733f01c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Resources | ||
|
||
## Resource Detector | ||
|
||
OpenTelemetry .NET SDK provides a resource detector for detecting resource | ||
information from the `OTEL_RESOURCE_ATTRIBUTES` and `OTEL_SERVICE_NAME` | ||
environment variables. | ||
|
||
Custom resource detectors can be implemented: | ||
|
||
* ResourceDetectors should inherit from | ||
`OpenTelemetry.Resources.IResourceDetector`, (which belongs to the | ||
[OpenTelemetry](../../src/OpenTelemetry/README.md) package), and implement | ||
the `Detect` method. | ||
|
||
A demo ResourceDetector is shown [here](../trace/extending-the-sdk/MyResourceDetector.cs). | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be better to simply show the code snippet to create a custom You could then add code snippets that show how to add this custom There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let me know if you would like to address these in this PR itself. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it would be good to give a background on what is resource etc. here in a follow up.