[sdk-metrics] MetricPoint lookup perf tweaks #5869
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Switch
LookupAggregatorStore
&LookupAggregatorStoreForDeltaWithReclaim
to return aref
to theMetricPoint
instead of the index to theMetricPoint
. For cases where we created aMetricPoint
, or reused one in the case of delta reclaim, this saves a second lookup/index/bounds-check into the array before the update is processed.Use
MemoryMarshal.GetArrayDataReference
on TFMs where it is supported to access the zero-tagMetricPoint
(index 0) and the overflowMetricPoint
(index 1) instead of performing a lookup/index/bounds-check on each measurement where they are used.Some renames to help with readability/clarity inside
AggregatorStore
...LookupAggregatorStore
->LookupMetricPoint
LookupAggregatorStoreForDeltaWithReclaim
->LookupMetricPointForDeltaWithReclaim
UpdateDoubleCustomTags
->UpdateDoubleWithTagFiltering
Benchmarks
TODO
Merge requirement checklist