Improving code coverage

[eddynaka]

Fixes #.

Changes

• Removing unused methods/constructors
• Adding more tests

For significant contributions please make sure you have completed the following items:

• Design discussion issue #
• Changes in public API reviewed

[codecov]

Codecov Report

Merging #939 into master will increase coverage by 1.64%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
+ Coverage   66.31%   67.96%   +1.64%     
==========================================
  Files         212      212              
  Lines        5994     5990       -4     
  Branches      967      967              
==========================================
+ Hits         3975     4071      +96     
+ Misses       1731     1641      -90     
+ Partials      288      278      -10     

Impacted Files	Coverage Δ
...Exporter.ZPages/TracerProviderBuilderExtensions.cs	81.81% <ø> (ø)
...ry.Instrumentation.AspNet/AspNetInstrumentation.cs	88.88% <ø> (+16.16%)	⬆️
...umentation.AspNetCore/AspNetCoreInstrumentation.cs	83.33% <ø> (+20.83%)	⬆️
...ation.SqlClient/TracerProviderBuilderExtensions.cs	100.00% <ø> (+28.57%)	⬆️
src/OpenTelemetry/Metrics/CounterMetricSdkBase.cs	80.00% <0.00%> (-13.34%)	⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs	60.81% <0.00%> (-2.71%)	⬇️
...ngeRedis/StackExchangeRedisCallsInstrumentation.cs	76.36% <0.00%> (+3.63%)	⬆️
...ensions.Hosting/OpenTelemetryServicesExtensions.cs	66.66% <0.00%> (+13.33%)	⬆️
...Exporter.Jaeger/TracerProviderBuilderExtensions.cs	81.81% <0.00%> (+18.18%)	⬆️
... and 10 more

[alanwest]

@eddynaka Looks like some nice improvements to test coverage. I'm generally interested in the approach you're taking to identify things to improve?

[eddynaka]

@eddynaka Looks like some nice improvements to test coverage. I'm generally interested in the approach you're taking to identify things to improve?

Hi @alanwest , i'm using two approaches: vs2019 style and codecov report. From codecov report (https://codecov.io/gh/open-telemetry/opentelemetry-dotnet/tree/feature%2Fimproving-codecoverage/src), we can see which files have the lowest coverage. With that in mind, i started to do that.

[eddynaka]

One thing that i still couldn't figure out is how to test EventSource. Injecting all the cases are hard, but at least we had to check the event and writeevent values.

[CodeBlanch]

LGTM, thanks for doing this @eddynaka!

[alanwest]

Hi @alanwest , i'm using two approaches: vs2019 style and codecov report. From codecov report (https://codecov.io/gh/open-telemetry/opentelemetry-dotnet/tree/feature%2Fimproving-codecoverage/src), we can see which files have the lowest coverage. With that in mind, i started to do that.

Cool, thanks for the tip! I'd clicked around codecov a bit, and was just curious about your workflow.

[eddynaka]

@alanwest, do u know how to test the event sources somehow?

[alanwest]

@alanwest, do u know how to test the event sources somehow?

@eddynaka Sorry for delay, just seeing this...

Just to be sure, is it the SqlEventSourceTests tests you're looking at? I haven't spent a lot of time looking at this test suite, but I welcome the opportunity at familiarizing myself more! Can you point me to a specific test you'd like to improve?