HTTPoision: use atoms for span keys #259
Open
+43
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The other http client implementations use atoms for span keys. Update the HTTPoison integration for consistency. This shouldn't have any impact other than in testing.
jeffutter
force-pushed
the
httpoison-normalize-span-key-type
branch
from
a24fd4e
to
1728ca5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other HTTP client implementations use atoms for span keys. Update the HTTPoison integration for consistency.
This shouldn't have any impact other than in testing.
This consistency is useful in that I'm working on a small suite of tests where I generate the same tests for each HTTP client and ensure they produce similar spans.