Instrument batching in opentelemetry_broadway #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mashton
requested review from
bryannaegele,
tsloughter and
whatyouhide
as code owners
|
Hi folks, pardon me if just opening a PR out of the blue is not the done thing here. I didn't see any guidance otherwise. I'd love to contribute to this and other otel projects in the ecosystem. |
whatyouhide
reviewed
Sep 2, 2024
instrumentation/opentelemetry_broadway/lib/opentelemetry_broadway.ex
Outdated
Show resolved
Hide resolved
Hooks into Broadway's batch processor start/stop events to add telemetry support to batching. Uses the the `topology` and `batcher` names to construct the span name. Span `kind` is :internal. Unsurprisingly, OpenTelemetry.SemanticConventions has no opinions about attribute names for batch processing. Instead we've namespaced a few novel attributes with `broadway.batch` and include message count, failed message count, and successfuly message count.
mashton
force-pushed
the
instrument-batching-opentelemetry_broadway
branch
from
b739ec4
to
32143da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooks into Broadway's batch processor start/stop events to add telemetry support to batching. Uses the the
topologyandbatchernames to construct the span name. Spankindis:internal.Unsurprisingly,
OpenTelemetry.SemanticConventionshas no opinions about attribute names for batch processing. Instead we've namespaced a few novel attributes withbroadway.batchand include message count, failed message count, and successfully message count.