Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelgrpc: Add status code attribute in accordance with the spec #439

Closed
matej-g opened this issue Nov 7, 2020 · 1 comment · Fixed by #453
Closed

otelgrpc: Add status code attribute in accordance with the spec #439

matej-g opened this issue Nov 7, 2020 · 1 comment · Fixed by #453
Assignees
Labels
area: instrumentation Related to an instrumentation package bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@matej-g
Copy link
Contributor

matej-g commented Nov 7, 2020

Although span status is no longer aligned with gRPC codes, according to the recent spec update, gRPC code should be reflected in the attributes.

Relevant part of the spec: https:/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/rpc.md#grpc-attributes

The gRPC interceptor should be adjusted accordingly.

@MrAlias MrAlias added area: instrumentation Related to an instrumentation package bug Something isn't working help wanted Extra attention is needed priority:p2 labels Nov 9, 2020
@MrAlias MrAlias added this to the RC1 milestone Nov 9, 2020
@matej-g
Copy link
Contributor Author

matej-g commented Nov 13, 2020

@MrAlias feel free to assign this to me as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants