Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

otelslog: Limit the size of kvBuffer returned to the pool #5334

Open
MrAlias opened this issue Mar 29, 2024 · 1 comment
Open

otelslog: Limit the size of kvBuffer returned to the pool #5334

MrAlias opened this issue Mar 29, 2024 · 1 comment
Labels
bridge: slog Related to the slog bridge

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 29, 2024

Limit the returned size so the pool doesn't hold on to very large buffers. Similar to https://cs.opensource.google/go/x/exp/+/814bf88c:slog/internal/buffer/buffer.go;l=27-34

Integration benchmark testing needs to be added along with the change to validate the performance improvement. Or this issue can be closed when that validation fails.

// TODO: limit returned size so the pool doesn't hold on to very large
// buffers. Idea is based on
// https://cs.opensource.google/go/x/exp/+/814bf88c:slog/internal/buffer/buffer.go;l=27-34

@MrAlias MrAlias added the bridge: slog Related to the slog bridge label Mar 29, 2024
@MrAlias MrAlias mentioned this issue Mar 29, 2024
8 tasks
@pellared pellared changed the title Limit the size of kvBuffer returned to the pool otelslog: Limit the size of kvBuffer returned to the pool Apr 3, 2024
@pellared
Copy link
Member

@MrAlias, I am removing it from Go: Logs (GA) as I do not see it as a GA blocker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bridge: slog Related to the slog bridge
Projects
None yet
Development

No branches or pull requests

2 participants