Add opencensus propagation readme and example #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
Aneurysm9,
evantorrie,
jmacd,
lizthegrey,
MrAlias and
XSAM
as code owners
dashpole
force-pushed
the
opencensus_binary_example
branch
from
ea54a99
to
d1ea4a4
Compare
MrAlias
requested changes
Dec 1, 2020
dashpole
force-pushed
the
opencensus_binary_example
branch
from
d1ea4a4
to
f3858c0
Compare
dashpole
force-pushed
the
opencensus_binary_example
branch
from
f3858c0
to
0c848c7
Compare
XSAM
approved these changes
Dec 2, 2020
MrAlias
approved these changes
Dec 2, 2020
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
#473) * Add `Span#Error` method to simplify setting an error status and message. * `Span#Error` should no-op on nil errors * Record errors as a span event rather than status/attributes. The implementation in the SDK package now relies on existing API methods. * Add WithErrorStatus() ErrorOption to allow setting span status on error. * Apply suggestions from code review Co-Authored-By: Krzesimir Nowak <[email protected]> * Address code review feedback * Clean up RecordError tests * Ensure complete and unique error type is recorded for defined types * Avoid duplicating logic under test in tests * Move TestError to internal/testing package, improve RecordError test scenarios Co-authored-by: Krzesimir Nowak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: open-telemetry/opentelemetry-go#93
Demonstrate propagation from an opencensus client to an opentelemetry server.