Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update module github.com/aws/aws-sdk-go-v2/service/dynamodb to v1.32.0 #5517

Merged
merged 2 commits into from
May 8, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 7, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
github.com/aws/aws-sdk-go-v2/service/dynamodb v1.31.1 -> v1.32.0 age adoption passing confidence

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot requested a review from Aneurysm9 as a code owner May 7, 2024 18:33
@renovate renovate bot requested a review from a team May 7, 2024 18:33
@renovate renovate bot added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label May 7, 2024
XSAM
XSAM previously approved these changes May 7, 2024
Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be fixed (a test fails after the bump).

CC @Aneurysm9

@renovate renovate bot force-pushed the renovate/aws-sdk-go-v2-monorepo branch from ce767e9 to 5cb1ef5 Compare May 7, 2024 18:52
@XSAM XSAM dismissed their stale review May 7, 2024 18:58

CI failed

@renovate renovate bot force-pushed the renovate/aws-sdk-go-v2-monorepo branch 2 times, most recently from 9c36d94 to 98d1657 Compare May 7, 2024 19:11
@pellared
Copy link
Member

pellared commented May 7, 2024

Fix by @Aneurysm9:

--- a/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes_test.go
+++ b/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/dynamodbattributes_test.go
@@ -122,7 +122,7 @@ func TestDynamodbTagsCreateTableInput(t *testing.T) {
        assert.Contains(t, attributes, attribute.StringSlice(
                "aws.dynamodb.global_secondary_indexes",
                []string{
-                       `{"IndexName":"index1","KeySchema":[{"AttributeName":"attributename","KeyType":"HASH"}],"Projection":{"NonKeyAttributes":["non-key-attributes"],"ProjectionType":""},"ProvisionedThroughput":null}`,
+                       `{"IndexName":"index1","KeySchema":[{"AttributeName":"attributename","KeyType":"HASH"}],"Projection":{"NonKeyAttributes":["non-key-attributes"],"ProjectionType":""},"OnDemandThroughput":null,"ProvisionedThroughput":null}`,
                },
        ))
        assert.Contains(t, attributes, attribute.StringSlice(
@@ -338,7 +338,7 @@ func TestDynamodbTagsUpdateTableInput(t *testing.T) {
        assert.Contains(t, attributes, attribute.StringSlice(
                "aws.dynamodb.global_secondary_index_updates",
                []string{
-                       `{"Create":{"IndexName":"index1","KeySchema":[{"AttributeName":"attribute","KeyType":"HASH"}],"Projection":{"NonKeyAttributes":["attribute1","attribute2"],"ProjectionType":"ALL"},"ProvisionedThroughput":null},"Delete":null,"Update":null}`,
+                       `{"Create":{"IndexName":"index1","KeySchema":[{"AttributeName":"attribute","KeyType":"HASH"}],"Projection":{"NonKeyAttributes":["attribute1","attribute2"],"ProjectionType":"ALL"},"OnDemandThroughput":null,"ProvisionedThroughput":null},"Delete":null,"Update":null}`,
                },
        ))
        assert.Contains(t, attributes, attribute.Float64("aws.dynamodb.provisioned_read_capacity", 123))

I will apply it when other renovate PRs are merged to avoid conflicts.

@renovate renovate bot force-pushed the renovate/aws-sdk-go-v2-monorepo branch 18 times, most recently from 7f5fa77 to 14ab2c9 Compare May 8, 2024 07:41
@renovate renovate bot force-pushed the renovate/aws-sdk-go-v2-monorepo branch from 14ab2c9 to 9f5aff3 Compare May 8, 2024 08:12
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.4%. Comparing base (1c626cd) to head (96a7140).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #5517     +/-   ##
=======================================
- Coverage   62.4%   62.4%   -0.1%     
=======================================
  Files        190     190             
  Lines      11646   11646             
=======================================
- Hits        7271    7269      -2     
- Misses      4159    4160      +1     
- Partials     216     217      +1     

see 1 file with indirect coverage changes

@pellared pellared merged commit aaa4a03 into main May 8, 2024
24 checks passed
@pellared pellared deleted the renovate/aws-sdk-go-v2-monorepo branch May 8, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants