-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk/trace: Log when an attribute/event/link is discarded due to limits #5343
Labels
area:trace
Part of OpenTelemetry tracing
enhancement
New feature or request
pkg:SDK
Related to an SDK package
Milestone
Comments
pellared
added
enhancement
New feature or request
pkg:SDK
Related to an SDK package
area:trace
Part of OpenTelemetry tracing
labels
May 9, 2024
Updating the title. There is not recommendation that truncated attributes be logged. |
MrAlias
changed the title
sdk/trace: Log when an attribute was discarded or truncated due to limits
sdk/trace: Log when an attribute was discarded due to limits
May 28, 2024
There is specification ambiguity about discarded events and links being logged. I'm going to assume open-telemetry/opentelemetry-specification#4064 lands and log for all. |
MrAlias
changed the title
sdk/trace: Log when an attribute was discarded due to limits
sdk/trace: Log when an attribute/event/link is discarded due to limits
May 28, 2024
MrAlias
added a commit
that referenced
this issue
May 30, 2024
…its (#5434) Fix #5343 - Update the `evictionQueue` to log when it drops a value - Update the `evictionQueue` to be declared over an `[T any]` parameter so it knows what to log when it is dropping a value and to reduce the `interface{}` allocation - Add a `clone` method to replace the now unneeded `interfaceArrayTo*Array` functions. - Update the `recordingSpan` to log once that is dropped an attribute when limits are reached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:trace
Part of OpenTelemetry tracing
enhancement
New feature or request
pkg:SDK
Related to an SDK package
From https:/open-telemetry/opentelemetry-specification/blob/main/specification/trace/sdk.md#span-limits:
The text was updated successfully, but these errors were encountered: