Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GCP Cloud Run resource attributes #4079

Closed

Conversation

damemi
Copy link
Contributor

@damemi damemi commented May 9, 2023

This adds the new attributes from open-telemetry/opentelemetry-specification#3378 to the Go semconv

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #4079 (f1fca8a) into main (6f04547) will decrease coverage by 0.1%.
The diff coverage is n/a.

❗ Current head f1fca8a differs from pull request most recent head d003b70. Consider uploading reports for the commit d003b70 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #4079     +/-   ##
=======================================
- Coverage   82.8%   82.8%   -0.1%     
=======================================
  Files        177     177             
  Lines      13494   13494             
=======================================
- Hits       11176   11174      -2     
- Misses      2097    2099      +2     
  Partials     221     221             

see 1 file with indirect coverage changes

@damemi damemi marked this pull request as draft May 9, 2023 14:49
@damemi damemi force-pushed the add-gcp-cloud-run-job-attrs branch from 8e8d6ad to d003b70 Compare May 9, 2023 14:49
@@ -916,6 +916,46 @@ func FaaSMaxMemory(val int) attribute.KeyValue {
return FaaSMaxMemoryKey.Int(val)
}

// Resource used by Google (GCP) Cloud Run
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you look at the very top of this file, you will see this is a generated file.

This doesn't do the needed work to add parsing into the tooling to generate these attributes from the actual source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MadVikingGod yeah sorry, I noticed that after I opened this. Switched it to a draft just so I have a placeholder but I can close it if that's easier.

Will these new resources just be automatically pulled in with the next release? Or will I need to open a PR to generate the files?

(btw, I checked a couple of the readmes and contributing files and it wasn't obvious to me what the workflow for updating these is)

@damemi
Copy link
Contributor Author

damemi commented May 11, 2023

Closing, asked about this in the sig meeting and it looks like my changes will be in the 1.21 release

@damemi damemi closed this May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants