-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update release lifecycle to support Conventional Commit, Release Please and automatic CHANGELOG #78
Comments
Hi @TylerHelmuth, I've noticed a discrepancy in the release notes under opentelemetry-collector-0.72.0. The content states "Full Changelog: opentelemetry-operator-0.39.2...opentelemetry-collector-0.72.0" and mentions both the operator and collector charts. Typically, release notes are specific to one project. Is this expected? I suspect something might be slightly off, I'll keep looking into the release notes code in case I missed something.. Side Note: I'm working on a collector chart distro project and adding a similar feature to support an ongoing CHANGELOG and release notes (#923). We would like to invest, help develop, and adopt the functionality in this project where possible so we can incorporate it into our distro. We can create or follow new GH issues as needed. Thank you! |
@jvoravong Good catch, I was not expecting that behavior. I will reopen this issue and investigate more tomorrow. |
Looking into this, the expected behavior for the github action is to generate "Full Changelog: opentelemetry-operator-0.39.2...opentelemetry-collector-0.72.0" since that is the exact changes between releases. The same behavior is happening in the prometheus helm chart repo: https:/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.3.0. Since every chart change is a release, comparing the differences between releases will always be an accurate way to show the files that changed for the release. I am curious about using |
…et is manually set in processors. (open-telemetry#78)
For ref: https:/google-github-actions/release-please-action
The text was updated successfully, but these errors were encountered: