Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release lifecycle to support Conventional Commit, Release Please and automatic CHANGELOG #78

Closed
pragmaticivan opened this issue Sep 15, 2021 · 3 comments · Fixed by #916
Labels
help wanted Extra attention is needed

Comments

@pragmaticivan
Copy link

For ref: https:/google-github-actions/release-please-action

@jvoravong
Copy link
Contributor

jvoravong commented Oct 11, 2023

Hi @TylerHelmuth,

I've noticed a discrepancy in the release notes under opentelemetry-collector-0.72.0. The content states "Full Changelog: opentelemetry-operator-0.39.2...opentelemetry-collector-0.72.0" and mentions both the operator and collector charts. Typically, release notes are specific to one project. Is this expected? I suspect something might be slightly off, I'll keep looking into the release notes code in case I missed something..

Side Note: I'm working on a collector chart distro project and adding a similar feature to support an ongoing CHANGELOG and release notes (#923). We would like to invest, help develop, and adopt the functionality in this project where possible so we can incorporate it into our distro. We can create or follow new GH issues as needed.

Thank you!

@TylerHelmuth
Copy link
Member

@jvoravong Good catch, I was not expecting that behavior. I will reopen this issue and investigate more tomorrow.

@TylerHelmuth TylerHelmuth reopened this Oct 11, 2023
@TylerHelmuth
Copy link
Member

Looking into this, the expected behavior for the github action is to generate "Full Changelog: opentelemetry-operator-0.39.2...opentelemetry-collector-0.72.0" since that is the exact changes between releases. The same behavior is happening in the prometheus helm chart repo: https:/prometheus-community/helm-charts/releases/tag/kube-prometheus-stack-51.3.0. Since every chart change is a release, comparing the differences between releases will always be an accurate way to show the files that changed for the release.

I am curious about using chloggen, but I view that as a potential improvement. I am going to close this issue again, but please open a new issue if you'd like to continue the discussion of how to incorporate chloggen for the 3 charts.

matej-g pushed a commit to matej-g/opentelemetry-helm-charts that referenced this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants