Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Role Binding subjects namespace incorrect when overriding namespace #953

Closed
nittendev opened this issue Nov 15, 2023 · 2 comments · Fixed by #960
Closed

Cluster Role Binding subjects namespace incorrect when overriding namespace #953

nittendev opened this issue Nov 15, 2023 · 2 comments · Fixed by #960
Labels
bug Something isn't working chart:collector Issue related to opentelemetry-collector helm chart good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nittendev
Copy link

Hi.

I've observed an issue when deploying the collector chart with an overriden namespace.
The clusterrolebinding gets the wrong subject namespace and incorrect access as a result.

I believe the issue is located here:
charts/opentelemetry-collector/templates/clusterrolebinding.yaml

Line 21:
namespace: {{ .Release.Namespace }}

I belive? it should be something like:
namespace: {{ template "opentelemetry-collector.namespace" . }}

@TylerHelmuth TylerHelmuth added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed chart:collector Issue related to opentelemetry-collector helm chart labels Nov 16, 2023
@etiennep
Copy link

I'd like to work on this.

@TylerHelmuth
Copy link
Member

@etiennep thank you, but there is already a PR submitted: #960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chart:collector Issue related to opentelemetry-collector helm chart good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants