Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentelemetry-operator] remove default limits for cpu and memory #970

Merged
merged 4 commits into from
Dec 15, 2023
Merged

[opentelemetry-operator] remove default limits for cpu and memory #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b27e3f1
[opentelemetry-operator] remove default limits for cpu and memory
Pionerd Nov 27, 2023
4caeaf5
adjusted schema and ran make commands
Pionerd Nov 27, 2023
039df6a
Merge branch 'main' into remove-resource-limits
Pionerd Dec 15, 2023
5dfc22d
Updated documentation
Pionerd Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/opentelemetry-operator/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: opentelemetry-operator
version: 0.44.1
version: 0.44.2
description: OpenTelemetry Operator Helm chart for Kubernetes
type: application
home: https://opentelemetry.io/
Expand Down
2 changes: 2 additions & 0 deletions charts/opentelemetry-operator/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ The following command will show all the configurable options with detailed comme
$ helm show values open-telemetry/opentelemetry-operator
```

When using this chart as a subchart, you may want to unset certain default values. Since Helm v3.13 values handling is improved and null can now consistently be used to remove values (e.g. to remove the default CPU limits).

## Install OpenTelemetry Collector

_See [OpenTelemetry website](https://opentelemetry.io/docs/collector/) for more details about the Collector_
Expand Down
4 changes: 2 additions & 2 deletions ...ator/examples/default/rendered/admission-webhooks/operator-webhook-with-cert-manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
annotations:
cert-manager.io/inject-ca-from: default/example-opentelemetry-operator-serving-cert
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down Expand Up @@ -91,7 +91,7 @@ metadata:
annotations:
cert-manager.io/inject-ca-from: default/example-opentelemetry-operator-serving-cert
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down
4 changes: 2 additions & 2 deletions charts/opentelemetry-operator/examples/default/rendered/certmanager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand All @@ -29,7 +29,7 @@ apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down
6 changes: 3 additions & 3 deletions charts/opentelemetry-operator/examples/default/rendered/clusterrole.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down Expand Up @@ -253,7 +253,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand All @@ -271,7 +271,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down
4 changes: 2 additions & 2 deletions charts/opentelemetry-operator/examples/default/rendered/clusterrolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand All @@ -25,7 +25,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down
2 changes: 1 addition & 1 deletion charts/opentelemetry-operator/examples/default/rendered/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down
2 changes: 1 addition & 1 deletion charts/opentelemetry-operator/examples/default/rendered/role.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down
2 changes: 1 addition & 1 deletion charts/opentelemetry-operator/examples/default/rendered/rolebinding.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down
4 changes: 2 additions & 2 deletions charts/opentelemetry-operator/examples/default/rendered/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: v1
kind: Service
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand All @@ -31,7 +31,7 @@ apiVersion: v1
kind: Service
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down
2 changes: 1 addition & 1 deletion charts/opentelemetry-operator/examples/default/rendered/serviceaccount.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: opentelemetry-operator
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down
2 changes: 1 addition & 1 deletion ...s/opentelemetry-operator/examples/default/rendered/tests/test-certmanager-connection.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: "example-opentelemetry-operator-cert-manager"
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down
4 changes: 2 additions & 2 deletions charts/opentelemetry-operator/examples/default/rendered/tests/test-service-connection.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: "example-opentelemetry-operator-metrics"
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down Expand Up @@ -43,7 +43,7 @@ metadata:
name: "example-opentelemetry-operator-webhook"
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.44.1
helm.sh/chart: opentelemetry-operator-0.44.2
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.90.0"
app.kubernetes.io/managed-by: Helm
Expand Down
10 changes: 2 additions & 8 deletions charts/opentelemetry-operator/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,10 +497,7 @@
"type": "object",
"default": {},
"title": "The limits Schema",
"required": [
"cpu",
"memory"
],
"required": [],
"properties": {
"cpu": {
"type": "string",
Expand Down Expand Up @@ -1108,10 +1105,7 @@
"type": "object",
"default": {},
"title": "The limits Schema",
"required": [
"cpu",
"memory"
],
"required": [],
"properties": {
"cpu": {
"type": "string",
Expand Down