Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we be capturing db.connection_string for Redis? #3080

Closed
trask opened this issue May 25, 2021 · 1 comment · Fixed by #3094
Closed

Should we be capturing db.connection_string for Redis? #3080

trask opened this issue May 25, 2021 · 1 comment · Fixed by #3094
Assignees

Comments

@trask
Copy link
Member

trask commented May 25, 2021

I noticed that some redis instrumentation captures db.connection_string:

  • redisson-3.0
  • jedis-1.4
  • jedis-3.0
  • lettuce-5.1

and some does not:

  • lettuce-4.0
  • lettuce-5.0
  • rediscala-1.8

Where we are capturing it, we are just concatenate host and port (which we capture in net.peer.* attributes already) to construct a synthetic connection string (as opposed to capturing some concept of connection string from redis itself).

fwiw, the redis example in the spec has not set for the db.connection_string value.

(also fwiw, my initial vote goes toward removing it)

@mateuszrzeszutek
Copy link
Member

db.connection_string probably makes the most sense for JDBC, where it can contain database name, properties, etc. If we have to produce a host:port string by ourselves it's probably better to remove it altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants