-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we be capturing db.connection_string for Redis? #3080
Comments
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that some redis instrumentation captures
db.connection_string
:and some does not:
Where we are capturing it, we are just concatenate host and port (which we capture in
net.peer.*
attributes already) to construct a synthetic connection string (as opposed to capturing some concept of connection string from redis itself).fwiw, the redis example in the spec has
not set
for thedb.connection_string
value.(also fwiw, my initial vote goes toward removing it)
The text was updated successfully, but these errors were encountered: