Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove http.target from metric attributes to control cardinality #5047

Closed
trask opened this issue Jan 7, 2022 · 1 comment · Fixed by #5081
Closed

Remove http.target from metric attributes to control cardinality #5047

trask opened this issue Jan 7, 2022 · 1 comment · Fixed by #5081
Assignees
Milestone

Comments

@trask
Copy link
Member

trask commented Jan 7, 2022

From @anuraaga's #4930 (comment):

For 1.10 we should go ahead and remove HTTP_TARGET from all metrics and live with it being gone until providing view configuration to javaagent users.

// Use http.target when http.route is not available.
if (!containsAttribute(SemanticAttributes.HTTP_ROUTE, startAttributes, endAttributes)) {
fullSet = durationServerFallbackView;
}

@jsuereth I know you had wanted http.target as a fallback since we aren't capturing http.route consistently yet, and metrics aren't nearly as useful without any route-like dimension. @mateuszrzeszutek has started the work on capturing http.route (#4852) but that work may not be finished in time for 1.10.0, so we need to make a decision on what to do in 1.10.0 release (and hopefully we'll have real solution, with http.route, in the next month or so).

@mateuszrzeszutek
Copy link
Member

@mateuszrzeszutek has started the work on capturing http.route (#4852) but that work may not be finished in time for 1.10.0

Yep, I might not be able to finish that this week (most likely not) - the micrometer work took a lot of time to finish. Should we just remove http.target for the time being? And/or add a property that allows including it as an attribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants