Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webflux client filter subscribe #2646

Merged
merged 12 commits into from
Mar 31, 2021
Merged

Fix webflux client filter subscribe #2646

merged 12 commits into from
Mar 31, 2021

Conversation

trask
Copy link
Member

@trask trask commented Mar 28, 2021

I should not be allowed to write reactive code 😞

anuraaga
anuraaga reviewed Mar 28, 2021
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test case we can add?

@iNikem iNikem self-requested a review March 30, 2021 05:29
@iNikem iNikem merged commit 0d11dbe into open-telemetry:main Mar 31, 2021
@trask trask mentioned this pull request Apr 3, 2021
Closed
@trask trask deleted the fix-webflux-client-filter-subscribe branch April 4, 2021 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@iNikem iNikem iNikem approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trask @anuraaga @iNikem @mateuszrzeszutek