Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude bootstrap dependencies from inst #3432

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Exclude bootstrap dependencies from inst #3432

merged 1 commit into from
Jun 29, 2021

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Jun 29, 2021

Resolves #3403

anuraaga
anuraaga approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - while working on the other PR I got to a point of reducing 393 duplicates to 129 or so. I guess those must have been these API ones.

To confirm, we need both, one to exclude bootstrap and one to prevent duplicate SDK files?

@laurit
Copy link
Contributor Author

laurit commented Jun 29, 2021

@anuraaga I believe there are two different kinds of duplicates. In the other PR you took care of duplicate jar entries for the exact same file. This PR is for duplicate files in jar root and inst. If a file is present in jar root AgentClassLoader will never load the one from inst so it shouldn't be needed.

@anuraaga anuraaga merged commit 9d1ab64 into open-telemetry:main Jun 29, 2021
@laurit laurit deleted the exclude-bootstrap-deps branch August 24, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@iNikem iNikem iNikem approved these changes

@mateuszrzeszutek mateuszrzeszutek mateuszrzeszutek approved these changes

@jkwatson jkwatson Awaiting requested review from jkwatson

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@trask trask Awaiting requested review from trask

@tylerbenson tylerbenson Awaiting requested review from tylerbenson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Otel api/context/semconv classes in inst/
4 participants
@laurit @anuraaga @iNikem @mateuszrzeszutek