Remove invalid message header #3958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
requested review from
anuraaga,
iNikem,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay and
tylerbenson
as code owners
anuraaga
reviewed
Aug 26, 2021
| private static final String SCOPE_KEY = | ||
| TracingChannelInterceptor.class.getName().replace('.', '_') + "_scope"; | ||
|
|
||
| private static final ThreadLocal<Map<MessageChannel, ContextAndScope>> LOCAL_CONTEXT_AND_SCOPE = |
There was a problem hiding this comment.
Any thoughts on InstrumentationContext<MessageChannel, ThreadLocal<ContextAndScope>>?
There was a problem hiding this comment.
Ah is this library instrumentation? Then Map is better indeed
anuraaga
approved these changes
Aug 26, 2021
| private static final String SCOPE_KEY = | ||
| TracingChannelInterceptor.class.getName().replace('.', '_') + "_scope"; | ||
|
|
||
| private static final ThreadLocal<Map<MessageChannel, ContextAndScope>> LOCAL_CONTEXT_AND_SCOPE = |
There was a problem hiding this comment.
Ah is this library instrumentation? Then Map is better indeed
mateuszrzeszutek
approved these changes
Aug 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsurprisingly #3863 didn't work out, since the header is still not serializable.
This PR implements @mateuszrzeszutek's #3863 (comment).