Introduce muzzle-specific interface to InstrumentationModule #4207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iNikem
requested review from
anuraaga,
jkwatson,
laurit,
mateuszrzeszutek,
pavolloffay,
trask and
tylerbenson
as code owners
iNikem
commented
Sep 27, 2021
| return ((InstrumentationModuleMuzzle) instrumentationModule).getMuzzleReferences(); | ||
| } | ||
|
|
||
| //Older classes created and compiled outside of this repo may not yet have the interface above. |
There was a problem hiding this comment.
Not sure if we should be backward-compatible here...
trask
approved these changes
Sep 27, 2021
.../java/io/opentelemetry/javaagent/tooling/instrumentation/InstrumentationModuleInstaller.java
Show resolved
Hide resolved
muzzle/src/main/java/io/opentelemetry/javaagent/tooling/muzzle/MuzzleReferencesAccessor.java
Show resolved
Hide resolved
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will contain all methods that muzzle automatically generates.