Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spring RMI instrumentation #5033

Merged
merged 11 commits into from
Jan 14, 2022

Conversation

Samudraneel24
Copy link
Contributor

Added instrumentation for Spring RMI.

@Samudraneel24 Samudraneel24 requested a review from a team January 7, 2022 05:57
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samudraneel24
Copy link
Contributor Author

@trask Thanks for the suggestions. I've fixed them and pushed a new commit but EasyCLA seems to be just stuck for me. Why could this be happening? I had already signed it earlier for this PR.

@trask
Copy link
Member

trask commented Jan 12, 2022

/easycla

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple comments, but overall it looks great! 👍
Thanks!

@Samudraneel24
Copy link
Contributor Author

Thanks for the suggestions @mateuszrzeszutek! I've made the changes.

Copy link
Member

@mateuszrzeszutek mateuszrzeszutek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@trask trask merged commit 3b0c490 into open-telemetry:main Jan 14, 2022
@Samudraneel24 Samudraneel24 deleted the springrmi-instrumentation branch January 15, 2022 10:57
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
* Spring RMI instrumentation

* Change the order of import statements

* remove extra separation in import statements

* stylistic changes

* Fix groovy rule violations

* Formatting changes in groovy file

* Spotless fixes and muzzle check version change

* Fixed minimum version in filenames and fixed muzzle check

* single InstrumentationModule and added context propagation test

* Merged singletons, use random port in test and add stricter matchers.

* Remove unused import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants